[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting durin
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting during a parse |
|
Date: |
Wed, 06 Jul 2016 17:06:30 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 06/07/2016 16:30, Markus Armbruster wrote:
>> Paolo Bonzini <address@hidden> writes:
>>
>>> Now that json-streamer tries not to leak tokens on incomplete parse,
>>> the tokens can be freed twice if QEMU destroys the json-streamer
>>> object during the parser->emit call. To fix this, create the new
>>> empty GQueue earlier, so that it is already in place when the old
>>> one is passed to parser->emit.
>>>
>>> Reported-by: Changlong Xie <address@hidden>
>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>
>> Reviewed-by: Markus Armbruster <address@hidden>
>>
>> Want me to do the pull request?
>
> I'm doing one tomorrow, so your choice.
Please include it in your pull request then.