[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-sockets: use qapi_free_SocketAddress in cl
|
From: |
Shannon Zhao |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-sockets: use qapi_free_SocketAddress in cleanup |
|
Date: |
Fri, 8 Jul 2016 16:15:06 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2016/7/7 0:42, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Commit 74b6ce43e3 uses the wrong free API for a SocketAddress, that
> may leak some linked data.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
I'm planing to send a patch, then I find this :)
Reviewed-by: Shannon Zhao <address@hidden>
> ---
> util/qemu-sockets.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index fb83d48..777af49 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -1012,7 +1012,7 @@ void socket_listen_cleanup(int fd, Error **errp)
> }
> }
>
> - g_free(addr);
> + qapi_free_SocketAddress(addr);
> }
>
> int socket_dgram(SocketAddress *remote, SocketAddress *local, Error **errp)
>
--
Shannon