[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helper
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers |
Date: |
Mon, 11 Jul 2016 15:38:14 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 11/07/16 15:36, Christian Borntraeger wrote:
> On 07/06/2016 11:14 PM, Sergey Fedorov wrote:
>> From: Alex Bennée <address@hidden>
>>
>> CPUState is a fairly common pointer to pass to these helpers. This means
>> if you need other arguments for the async_run_on_cpu case you end up
>> having to do a g_malloc to stuff additional data into the routine. For
>> the current users this isn't a massive deal but for MTTCG this gets
>> cumbersome when the only other parameter is often an address.
>>
>> This adds the typedef run_on_cpu_func for helper functions which has an
>> explicit CPUState * passed as the first parameter. All the users of
>> run_on_cpu and async_run_on_cpu have had their helpers updated to use
>> CPUState where available.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> [Sergey Fedorov:
>> - eliminate more CPUState in user data;
>> - remove unnecessary user data passing;
>> - fix target-s390x/kvm.c and target-s390x/misc_helper.c]
>> Signed-off-by: Sergey Fedorov <address@hidden>
>> ---
>>
>> Changes in v2:
>> - eliminate more CPUState in user data
>> - remove unnecessary user data passing
>> - fix target-s390x/kvm.c and target-s390x/misc_helper.c
>>
>> ---
>> cpus.c | 15 ++++---
>> hw/i386/kvm/apic.c | 3 +-
>> hw/i386/kvmvapic.c | 6 +--
>> hw/ppc/ppce500_spin.c | 31 +++++----------
>> hw/ppc/spapr.c | 6 +--
>> hw/ppc/spapr_hcall.c | 17 ++++----
>> include/qom/cpu.h | 8 ++--
>> kvm-all.c | 21 ++++------
>> target-i386/helper.c | 19 ++++-----
>> target-i386/kvm.c | 6 +--
>> target-s390x/cpu.c | 4 +-
>> target-s390x/cpu.h | 7 +---
>> target-s390x/kvm.c | 98
>> +++++++++++++++++++++++-----------------------
>> target-s390x/misc_helper.c | 4 +-
>> 14 files changed, 108 insertions(+), 137 deletions(-)
> s390 parts look ok.
Can this be considered as "Acked-by" or not exactly?
Thanks,
Sergey
- [Qemu-devel] [RFC v2 00/11] cpu-exec: Safe work in quiescent state, Sergey Fedorov, 2016/07/06
- [Qemu-devel] [RFC v2 04/11] cpus: Wrap mutex used to protect CPU work, Sergey Fedorov, 2016/07/06
- [Qemu-devel] [RFC v2 05/11] cpus: Rename flush_queued_work(), Sergey Fedorov, 2016/07/06
- [Qemu-devel] [RFC v2 07/11] linux-user: Rework exclusive operation mechanism, Sergey Fedorov, 2016/07/06
- [Qemu-devel] [RFC v2 06/11] linux-user: Use QemuMutex and QemuCond, Sergey Fedorov, 2016/07/06
- [Qemu-devel] [RFC v2 08/11] linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick(), Sergey Fedorov, 2016/07/06