Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select

[Peter Maydell]

On 8 July 2016 at 00:17, Laurent Vivier <address@hidden> wrote:
> TARGET_NR_select can have three different implementations:
>
>   1- to always return -ENOSYS
>
>      microblaze, ppc, ppc64
>
>      -> TARGET_WANT_NI_OLD_SELECT
>
>   2- to take parameters from a structure pointed by arg1
>     (kernel sys_old_select)
>
>      i386, arm, m68k
>
>      -> TARGET_WANT_OLD_SYS_SELECT
>
>   3- to take parameters from arg[1-5]
>      (kernel sys_select)
>
>      x86_64, alpha, s390x,
>      cris, sparc, sparc64
>
> Some (new) architectures don't define NR_select,
>
>   4- but only NR__newselect with sys_select:
>
>       mips, mips64, sh
>
>   5- don't define NR__newselect, and use pselect6 syscall:
>
>       aarch64, openrisc, tilegx, unicore32
>
> Reported-by: Timothy Pearson <address@hidden>
> Reported-by: Allan Wirth <address@hidden>
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM