Re: [Qemu-devel] [PATCH 1/6] virtio-bus: Drop "set_handler" parameter

[Cornelia Huck]

On Tue, 12 Jul 2016 17:16:42 +0800
Fam Zheng <address@hidden> wrote:

> On Tue, 07/12 11:09, Cornelia Huck wrote:
> > On Tue, 12 Jul 2016 13:19:55 +0800

> > > @@ -269,7 +268,7 @@ int virtio_bus_set_host_notifier(VirtioBusState *bus, 
> > > int n, bool assign)
> > >           */
> > >          virtio_bus_stop_ioeventfd(bus);
> > >      }
> > > -    return set_host_notifier_internal(proxy, bus, n, assign, false);
> > > +    return set_host_notifier_internal(proxy, bus, n, assign);
> > 
> > ...because this changes the behaviour for assign==true.
> 
> Oh this is the one I overlook in rebase because it wasn't present with your
> refactoring but it is now back in commit 0830c96d70b.

Yes, we need to come up with a proper solution, but I currently don't
see this for 2.7.

> 
> Good catch, I need to fix this, and therefore Stefan's r-b shouldn't have been
> kept along.

The whole host notifier stuff is good at causing headaches :(