[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-comm
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit |
|
Date: |
Thu, 14 Jul 2016 09:14:52 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/14/2016 07:28 AM, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> block-commit to accept a node-name without lifting the restriction that
> we're operating at a root node.
>
> As libvirt makes use of the DeviceNotFound error class, we must add
> explicit code to retain this behaviour because qmp_get_root_bs() only
> returns GenericErrors.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 23 +++++++++++------------
> qapi/block-core.json | 2 +-
> qmp-commands.hx | 2 +-
> 3 files changed, 13 insertions(+), 14 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature