[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run |
Date: |
Thu, 14 Jul 2016 10:19:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/14/2016 07:33 AM, Denis V. Lunev wrote:
> The code inside the helper will be extended in the next patch. mirror_run
> itself is overbloated at the moment.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy<address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
I did NOT give R-b on v2 3/7. In particular, this patch has semantic
changes that I requested on v2, and so you want to make sure I re-review
it (I often skip re-reviewing a patch that has my R-b listed, on the
grounds that I'm trusting your judgment that it hasn't substantially
changed since my last time through it; but here, you have changed it
since last time).
> Reviewed-by: Fam Zheng <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Eric Blake <address@hidden>
> ---
> block/mirror.c | 70
> ++++++++++++++++++++++++++++++++++------------------------
> 1 file changed, 41 insertions(+), 29 deletions(-)
That said, I've looked through the changes (the rebase on top of moving
last_pause_ns to being a member of s, so that a single timestamp is
shared across both functions), and can now safely state:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 5/8] block: remove extra condition in bdrv_can_write_zeroes_with_unmap, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 6/8] mirror: optimize dirty bitmap filling in mirror_run a bit, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 2/8] mirror: make sectors_in_flight int64_t, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run, Denis V. Lunev, 2016/07/14
- Re: [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run,
Eric Blake <=
- [Qemu-devel] [PATCH v3 7/8] mirror: efficiently zero out target, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: operate with int64_t amount, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 8/8] mirror: improve performance of mirroring of empty disk, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 3/8] mirror: create mirror_throttle helper, Denis V. Lunev, 2016/07/14
- Re: [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements, Denis V. Lunev, 2016/07/18
- Re: [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements, Jeff Cody, 2016/07/19