[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code
|
From: |
Hulin, Patrick - 0559 - MITLL |
|
Subject: |
Re: [Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code |
|
Date: |
Fri, 15 Jul 2016 19:49:39 +0000 |
Hi all,
Just noticed this patch and wanted to leave a quick comment. The original
issue wasn't with cross-page writes - it was with cross-TB writes.
Cross-page writes become an issue once you reverse the order of the loop, so
that part of the patch is necessary. But someone might want to leave a note
in the code that there's still an issue when doing an unaligned write off
the front of a TB. The patch fixes the behavior of vanilla Windows 7 x64,
which is definitely an improvement, but there are a few real applications
that break it. (Photoshop is one, I believe).
-Patrick
smime.p7s
Description: S/MIME cryptographic signature
- [Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code, Richard Henderson, 2016/07/08
- [Qemu-devel] [PULL 2/4] cputlb: Add address parameter to VICTIM_TLB_HIT, Richard Henderson, 2016/07/08
- [Qemu-devel] [PULL 3/4] cputlb: Fix for self-modifying writes across page boundaries, Richard Henderson, 2016/07/08
- [Qemu-devel] [PULL 4/4] translate-all: Fix user-mode self-modifying code in 2 page long TB, Richard Henderson, 2016/07/08
- [Qemu-devel] [PULL 1/4] cputlb: Move VICTIM_TLB_HIT out of line, Richard Henderson, 2016/07/08
- Re: [Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code, Peter Maydell, 2016/07/11
- Re: [Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code,
Hulin, Patrick - 0559 - MITLL <=