[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Symlink README.md as README to unbreak checkpat
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] Symlink README.md as README to unbreak checkpatch.pl |
Date: |
Wed, 20 Jul 2016 11:42:19 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jul 20, 2016 at 11:36:36AM +0100, Peter Maydell wrote:
> On 20 July 2016 at 08:27, Fam Zheng <address@hidden> wrote:
> > Commit e5dfc5e8e71 renamed README to README.md but scripts/checkpatch.pl
> > still looks for the old name to sanity check that it's invoked from the
> > toplevel of tree.
> >
> > Create a symbol link to README.md to fix that. I've verified that on
> > github README.md still takes precedence and page is rendered.
>
> Have you checked that the symlink does sensible things if the git
> tree is checked out under Windows?
Should be fine
https://www.kernel.org/pub/software/scm/git/docs/git-config.html
"core.symlinks
If false, symbolic links are checked out as small plain files that
contain the link text. git-update-index(1) and git-add(1) will not
change the recorded type to regular file. Useful on filesystems like
FAT that do not support symbolic links.
The default is true, except git-clone(1) or git-init(1) will probe
and set core.symlinks false if appropriate when the repository is
created."
IOW, git will just "do the right thing" and automatically default
core.symlinks to false on FAT.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Re: [Qemu-devel] [PATCH] Symlink README.md as README to unbreak checkpatch.pl, Stefan Hajnoczi, 2016/07/20