[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-sh4: Use glib allocator in movcal helper
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target-sh4: Use glib allocator in movcal helper |
Date: |
Thu, 21 Jul 2016 13:44:45 +0100 |
Ping?
thanks
-- PMM
On 12 July 2016 at 13:50, Peter Maydell <address@hidden> wrote:
> Coverity spots that helper_movcal() calls malloc() but doesn't
> check for failure. Fix this by switching to the glib allocation
> functions, which abort on allocation failure.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target-sh4/op_helper.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/target-sh4/op_helper.c b/target-sh4/op_helper.c
> index 303e83e..40dd1cf 100644
> --- a/target-sh4/op_helper.c
> +++ b/target-sh4/op_helper.c
> @@ -109,7 +109,8 @@ void helper_movcal(CPUSH4State *env, uint32_t address,
> uint32_t value)
> {
> if (cpu_sh4_is_cached (env, address))
> {
> - memory_content *r = malloc (sizeof(memory_content));
> + memory_content *r = g_new(memory_content, 1);
> +
> r->address = address;
> r->value = value;
> r->next = NULL;
> @@ -126,7 +127,7 @@ void helper_discard_movcal_backup(CPUSH4State *env)
> while(current)
> {
> memory_content *next = current->next;
> - free (current);
> + g_free(current);
> env->movcal_backup = current = next;
> if (current == NULL)
> env->movcal_backup_tail = &(env->movcal_backup);
> @@ -149,7 +150,7 @@ void helper_ocbi(CPUSH4State *env, uint32_t address)
> env->movcal_backup_tail = current;
> }
>
> - free (*current);
> + g_free(*current);
> *current = next;
> break;
> }
> --
> 1.9.1