Re: [Qemu-devel] [PATCH 26/37] sd: free timer

[Marc-André Lureau]

Hi

On Thu, Jul 21, 2016 at 8:53 PM, Andrew Baumann
<address@hidden> wrote:
> Thanks for the fix. This was based on some other timer code I found in the 
> tree that was evidently also leaky (I don't remember where unfortunately).
>
> One thing: are you sure it is safe to call timer_del() again if the timer may 
> already have been deleted? It looks that way from the implementation, but the 
> header comment isn't explicit.

Yes, it is safe, afaik, it's removing it from the list of active timers.

> Otherwise,
> Reviewed-by: Andrew Baumann <address@hidden>

thanks



-- 
Marc-André Lureau