Re: [Qemu-devel] [PATCH v22 10/10] support replication driver in blockdev-add

[Changlong Xie]

On 07/26/2016 07:00 AM, Max Reitz wrote:
> On 22.07.2016 12:16, Wang WeiWei wrote:
> > From: Wen Congyang <address@hidden>
> >
> > Signed-off-by: Wen Congyang <address@hidden>
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Gonglei <address@hidden>
> > Signed-off-by: Changlong Xie <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
> > Signed-off-by: Wang WeiWei <address@hidden>
> > ---
> >   qapi/block-core.json | 19 +++++++++++++++++--
> >   1 file changed, 17 insertions(+), 2 deletions(-)
> >
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 7f05b68..59565e9 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -248,6 +248,7 @@
> >   #       2.3: 'host_floppy' deprecated
> >   #       2.5: 'host_floppy' dropped
> >   #       2.6: 'luks' added
> > +#       2.7: 'replication' added
>
> Probably 2.8

yes

> >   #
> >   # @backing_file: #optional the name of the backing file (for copy-on-write)
> >   #
> > @@ -1696,8 +1697,8 @@
> >     'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
> >               'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
> >               'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co',
> > -            'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp',
> > -            'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
> > +            'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 
> > 'replication',
> > +            'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
> >
> >   ##
> >   # @BlockdevOptionsFile
> > @@ -2160,6 +2161,19 @@
> >   { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
> >
> >   ##
> > +# @BlockdevOptionsReplication
> > +#
> > +# Driver specific block device options for replication
> > +#
> > +# @mode: the replication mode
>
> What about top-id?

Sorry, i'll add it in next version

> > +#
> > +# Since: 2.7
>
> 2.8

yes.

> Max
>
> > +##
> > +{ 'struct': 'BlockdevOptionsReplication',
> > +  'base': 'BlockdevOptionsGenericFormat',
> > +  'data': { 'mode': 'ReplicationMode'  } }
> > +
> > +##
> >   # @BlockdevOptions
> >   #
> >   # Options for creating a block device.  Many options are available for all
> > @@ -2224,6 +2238,7 @@
> >         'quorum':     'BlockdevOptionsQuorum',
> >         'raw':        'BlockdevOptionsGenericFormat',
> >   # TODO rbd: Wait for structured options
> > +      'replication':'BlockdevOptionsReplication',
> >   # TODO sheepdog: Wait for structured options
> >   # TODO ssh: Should take InetSocketAddress for 'host'?
> >         'tftp':       'BlockdevOptionsFile',