[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] R: [PATCH v2] Unbreak FreeBSD build after optionrom upd
|
From: |
Sean Bruno |
|
Subject: |
Re: [Qemu-devel] R: [PATCH v2] Unbreak FreeBSD build after optionrom update. |
|
Date: |
Tue, 26 Jul 2016 15:07:40 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 07/26/16 03:32, Paolo Bonzini wrote:
>
>> Update the build flags appropriately for FreeBSD and add the correct
>> LD_EMULATION type for the FreeBSD build case.
>>
>> Signed-off-by: Sean Bruno <address@hidden>
>
> I posted the right fix a couple days ago, but didn't manage to send a pull
> request before leaving and I am on mobile until next Monday.
>
> Search the archive for cc-c-option to get the right fix.
>
> Also, the commit message for a build fix patch really should include the
> error message, so please do that even if your v3 only includes the change to
> the emulation name.
>
> Thanks,
>
> Paolo
>
Paolo:
Thanks for the pointer to the right fix. Confirmed that your changes
DTRT for FreeBSD.
I still need the LD_EMULATION addition, which I have sent to the list as
a separate patch for review.
sean
signature.asc
Description: OpenPGP digital signature