[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to
From: |
Dave Hansen |
Subject: |
Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info |
Date: |
Wed, 27 Jul 2016 09:40:56 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 07/26/2016 06:23 PM, Liang Li wrote:
> + for_each_migratetype_order(order, t) {
> + list_for_each(curr, &zone->free_area[order].free_list[t]) {
> + pfn = page_to_pfn(list_entry(curr, struct page, lru));
> + if (pfn >= start_pfn && pfn <= end_pfn) {
> + page_num = 1UL << order;
> + if (pfn + page_num > end_pfn)
> + page_num = end_pfn - pfn;
> + bitmap_set(bitmap, pfn - start_pfn, page_num);
> + }
> + }
> + }
Nit: The 'page_num' nomenclature really confused me here. It is the
number of bits being set in the bitmap. Seems like calling it nr_pages
or num_pages would be more appropriate.
Isn't this bitmap out of date by the time it's send up to the
hypervisor? Is there something that makes the inaccuracy OK here?
Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process, Michael S. Tsirkin, 2016/07/27
Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process, Michael S. Tsirkin, 2016/07/27
[Qemu-devel] [PATCH v2 repost 5/7] virtio-balloon: define feature bit and head for misc virt queue, Liang Li, 2016/07/26
[Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info, Liang Li, 2016/07/26
- Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info,
Dave Hansen <=
Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info, Li, Liang Z, 2016/07/27
Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info, Michael S. Tsirkin, 2016/07/27
Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info, Michael S. Tsirkin, 2016/07/27
[Qemu-devel] [PATCH v2 repost 7/7] virtio-balloon: tell host vm's free page info, Liang Li, 2016/07/26