Re: [Qemu-devel] [PATCH v2 2/2] util: Drop inet_listen()

[Cao jin]

On 07/27/2016 07:36 PM, Daniel P. Berrange wrote:
> On Mon, Jul 25, 2016 at 09:02:51PM +0800, Cao jin wrote:
> > Since commit e65c67e4, inet_listen() is not used anymore, and all
> > inet listen operation goes through QIOChannel.
> >
> > Cc: Daniel P. Berrange <address@hidden>
> > Cc: Gerd Hoffmann <address@hidden>
> > Cc: Paolo Bonzini <address@hidden>
> > Cc: Eric Blake <address@hidden>
> >
> > Signed-off-by: Cao jin <address@hidden>
> > ---
> >   include/qemu/sockets.h |  2 --
> >   util/qemu-sockets.c    | 28 ----------------------------
> >   2 files changed, 30 deletions(-)
>
> Reviewed-by: Daniel P. Berrange <address@hidden>
>
> > diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
> > index 28a28c0..9eb2470 100644
> > --- a/include/qemu/sockets.h
> > +++ b/include/qemu/sockets.h
> > @@ -33,8 +33,6 @@ int socket_set_fast_reuse(int fd);
> >   typedef void NonBlockingConnectHandler(int fd, Error *err, void *opaque);
>
> There's still scope for a 3rd patch to remove this NonBlockingConnectHandler
> typedef, since nothing uses it anymore.

Definitely, I am working on the patch that remove the whole obsolete 
non-blocking connecting mechanism.

> Regards,
> Daniel

--
Yours Sincerely,

Cao jin