Re: [Qemu-devel] [PATCH] linux-user: Use correct alignment for long long on i386 guests

[Peter Maydell]

On 1 August 2016 at 10:04, Riku Voipio <address@hidden> wrote:
> On Thu, Jul 28, 2016 at 12:57:59PM +0100, Peter Maydell wrote:
>> For i386, the ABI specifies that 'long long' (8 byte values)
>> need only be 4 aligned, but we were requiring them to be
>> 8-aligned. This meant we were laying out the target_epoll_event
>> structure wrongly. Add a suitable ifdef to abitypes.h to
>> specify the i386-specific alignment requirement.
>
> Thanks, applied all your patches upto this patch to:
>
> https://git.linaro.org/people/riku.voipio/qemu.git/shortlog/refs/heads/for-next
>
> I take none of the patches are important enough to warrant including
> in 2.7?

I think I would suggest at least these for 2.7:

linux-user: Use correct alignment for long long on i386 guests


 (fixes a real user-reported bug)
linux-user: Fix memchr() argument in open_self_cmdline()
linux-user: Don't write off end of new_utsname buffer
 (both buffer overruns that could plausibly happen)
linux-user: Fix target_semid_ds structure definition
 (sysv semaphore completely broken on many guest archs)
linux-user: Handle brk() attempts with very large sizes
 (because I'd like to be able to tell the gcc folks they
  can just test with QEMU 2.7)

with perhaps the rest of the coverity-fixes on the
maybe list.

thanks
-- PMM