Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()

[Marc-André Lureau]

Hi

----- Original Message -----
> address@hidden writes:
> 
> > From: Marc-André Lureau <address@hidden>
> >
> > Replace the old manual dispatch and validation code by the generic one
> > provided by qapi common code.
> >
> > Note that it is now possible to call the following commands that used to
> > be disabled by compile-time conditionals:
> > - dump-skeys
> > - query-spice
> > - rtc-reset-reinjection
> > - query-gic-capabilities
> >
> > Their fallback functions return an appropriate "feature disabled" error.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> 
> Means query-qmp-schema no longer shows whether these commands are
> supported, doesn't it?
> 
> Eric, could this create difficulties for libvirt or other introspection
> users?

Thinking a bit about this, I guess it would be fairly straightforward to have a 
new key "c-conditional" : "#ifdef CONFIG_SPICE" that would prepend it in C 
generated files, with a corresponding "#endif". Would that be acceptable?