Re: [Qemu-devel] [PATCH for-2.8 v1 08/60] trace: provide mechanism for registering trace events

[Daniel P. Berrange]

On Tue, Aug 09, 2016 at 06:17:04PM +0200, Paolo Bonzini wrote:
> 
> 
> On 09/08/2016 17:31, Daniel P. Berrange wrote:
> > +    out('void trace_register_events(void)',
> > +        '{',
> > +        '    trace_event_register_group(trace_events, TRACE_EVENT_COUNT);',
> > +        '}',
> > +        'trace_init(trace_register_events)')
> 
> Should this function be static?

Yes it should be actually - left over from before I was using the
qemu-module support to register these.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|