Re: [Qemu-devel] [PATCH 1/5] checkpatch: tweak the files in which TABs are checked

[Cornelia Huck]

On Wed, 10 Aug 2016 05:02:53 -0400 (EDT)
Paolo Bonzini <address@hidden> wrote:

> ----- Original Message -----
> > From: "Cornelia Huck" <address@hidden>
> > To: "Paolo Bonzini" <address@hidden>
> > Cc: address@hidden, address@hidden, address@hidden, address@hidden
> > Sent: Wednesday, August 10, 2016 10:57:30 AM
> > Subject: Re: [PATCH 1/5] checkpatch: tweak the files in which TABs are 
> > checked
> > 
> > On Wed, 10 Aug 2016 10:22:46 +0200
> > Paolo Bonzini <address@hidden> wrote:
> > 
> > > Include Python and shell scripts, and make an exception for Perl
> > > scripts we imported from Linux or elsewhere.
> > > 
> > > Signed-off-by: Paolo Bonzini <address@hidden>
> > > ---
> > >  scripts/checkpatch.pl | 9 +++++----
> > >  1 file changed, 5 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > index 8d1813e..082c4ce 100755
> > > --- a/scripts/checkpatch.pl
> > > +++ b/scripts/checkpatch.pl
> > > @@ -1334,7 +1334,7 @@ sub process {
> > >           }
> > > 
> > >  # check we are in a valid source file if not then ignore this hunk
> > > -         next if ($realfile !~ /\.(h|c|cpp|s|S|pl|sh)$/);
> > > +         next if ($realfile !~ /\.(h|c|cpp|s|S|pl|py|sh)$/);
> > 
> > Do all of our checks work for python as well?
> 
> Only these:
> 
>                                 ERROR("line over 90 characters\n" . 
> $herecurr);
>                                 WARN("line over 80 characters\n" . $herecurr);
>                         ERROR("unnecessary whitespace before a quoted 
> newline\n" . $herecurr);
>                         ERROR("adding a line without newline at end of 
> file\n" . $herecurr);
>                         ERROR("CVS style keyword markers, these will _not_ be 
> updated\n". $herecurr);
>                         ERROR("code indent should never use tabs\n" . 
> $herevet);
> 
> After which there is a
> 
> # check we are in a valid C source file if not then ignore this hunk
>                 next if ($realfile !~ /\.(h|c|cpp)$/);
> 
> > Looks reasonable. Do you plan to include the "skip header updates"
> > patch as well?
> 
> Yes.

Thanks for clarifying (and for doing the work!)

Acked-by: Cornelia Huck <address@hidden>