Re: [Qemu-devel] [PATCH v4 00/17] qapi: remove the 'middle' mode

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v4 00/17] qapi: remove the 'middle' mode
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
11826ee qmp-commands.txt: fix some styling
efdce7f Replace qmp-commands.hx by doc/qmp-commands.txt
59685a4 build-sys: remove qmp-commands-old.h
43a8282 monitor: use qmp_dispatch()
ee6f707 qmp: update qmp_query_spice fallback
be382f6 qapi: check invalid arguments on no-args commands
0d01f13 qapi: remove the "middle" mode
d8a1541 monitor: remove mhandler.cmd_new
a489768 monitor: implement 'qmp_query_commands' without qmp_cmds
d4647e8 monitor: use qmp_find_command() (using generated qapi code)
3616d53 qapi: export the marshallers
a704864 monitor: unregister conditional commands
fae5991 monitor: register gen:false commands manually
6b689b4 monitor: simplify invalid_qmp_mode()
3952e05 qapi-schema: add 'device_add'
5481a61 qapi-schema: use generated marshaller for 'qmp_capabilities'
d3cbddf build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}

=== OUTPUT BEGIN ===
Checking PATCH 1/17: build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}...
Checking PATCH 2/17: qapi-schema: use generated marshaller for 
'qmp_capabilities'...
Checking PATCH 3/17: qapi-schema: add 'device_add'...
Checking PATCH 4/17: monitor: simplify invalid_qmp_mode()...
Checking PATCH 5/17: monitor: register gen:false commands manually...
Checking PATCH 6/17: monitor: unregister conditional commands...
Checking PATCH 7/17: qapi: export the marshallers...
WARNING: line over 80 characters
#28: FILE: scripts/qapi-commands.py:87:
+    return 'void qmp_marshal_%s(QDict *args, QObject **ret, Error **errp)' % 
c_name(name)

total: 0 errors, 1 warnings, 20 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/17: monitor: use qmp_find_command() (using generated qapi 
code)...
Checking PATCH 9/17: monitor: implement 'qmp_query_commands' without qmp_cmds...
Checking PATCH 10/17: monitor: remove mhandler.cmd_new...
Checking PATCH 11/17: qapi: remove the "middle" mode...
Checking PATCH 12/17: qapi: check invalid arguments on no-args commands...
Checking PATCH 13/17: qmp: update qmp_query_spice fallback...
Checking PATCH 14/17: monitor: use qmp_dispatch()...
Checking PATCH 15/17: build-sys: remove qmp-commands-old.h...
Checking PATCH 16/17: Replace qmp-commands.hx by doc/qmp-commands.txt...
ERROR: trailing whitespace
#168: FILE: docs/qmp-commands.txt:73:
+Arguments: $

ERROR: trailing whitespace
#1660: FILE: docs/qmp-commands.txt:1565:
+Arguments: $

ERROR: trailing whitespace
#2386: FILE: docs/qmp-commands.txt:2291:
+   $

ERROR: trailing whitespace
#2403: FILE: docs/qmp-commands.txt:2308:
+   $

ERROR: trailing whitespace
#2787: FILE: docs/qmp-commands.txt:2692:
+               (such as RDMA pinning) which may be expensive, but do not $

ERROR: trailing whitespace
#2788: FILE: docs/qmp-commands.txt:2693:
+               actually occur during the iterative migration rounds $

total: 6 errors, 0 warnings, 3901 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 17/17: qmp-commands.txt: fix some styling...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden