Re: [Qemu-devel] [PATCH 0/2] error-report: introduce error_report_exit()

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/2] error-report: introduce error_report_exit()
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8ca226c error-report: leveraging error_report_exit()
dccdb8b error-report: provide error_report_exit()

=== OUTPUT BEGIN ===
Checking PATCH 1/2: error-report: provide error_report_exit()...
Checking PATCH 2/2: error-report: leveraging error_report_exit()...
WARNING: line over 80 characters
#335: FILE: hw/arm/sabrelite.c:53:
+        error_report_exit("RAM size " RAM_ADDR_FMT " above max supported 
(%08x)",

WARNING: line over 80 characters
#475: FILE: hw/arm/virt.c:1199:
+            error_report_exit("Unable to determine GIC version supported by 
host");

WARNING: line over 80 characters
#515: FILE: hw/arm/virt.c:1247:
+            error_report_exit("mach-virt: KVM does not support Security 
extensions");

WARNING: line over 80 characters
#662: FILE: hw/core/platform-bus.c:157:
+        error_report_exit("Platform Bus: Can not fit MMIO region of size %" 
PRIx64,

WARNING: line over 80 characters
#757: FILE: hw/i386/pc.c:1424:
+            error_report_exit("unsupported amount of maximum memory: " 
RAM_ADDR_FMT,

WARNING: line over 80 characters
#768: FILE: hw/i386/pc.c:2089:
+        error_report_exit("System Management Mode not supported by this 
hypervisor.");

ERROR: line over 90 characters
#845: FILE: hw/intc/xics_kvm.c:68:
+        error_report_exit("Unable to retrieve KVM interrupt controller state" 
" for CPU %ld: %s",

ERROR: line over 90 characters
#857: FILE: hw/intc/xics_kvm.c:164:
+            error_report_exit("Unable to retrieve KVM interrupt controller 
state" " for IRQ %d: %s",

WARNING: line over 80 characters
#1049: FILE: hw/net/virtio-net.c:1136:
+            error_report_exit("virtio-net receive queue contains no in 
buffers");

WARNING: line over 80 characters
#1207: FILE: hw/ppc/mac_oldworld.c:250:
+            error_report_exit("Bus model not supported on OldWorld Mac 
machine");

WARNING: line over 80 characters
#1394: FILE: hw/ppc/spapr.c:1786:
+        error_report_exit("Numa node 0 has to span the RMA (%#08" HWADDR_PRIx 
")",

ERROR: line over 90 characters
#1427: FILE: hw/ppc/spapr.c:1878:
+            error_report_exit("Specified number of memory slots %" PRIu64 " 
exceeds max supported %d",

ERROR: line over 90 characters
#1469: FILE: hw/ppc/spapr.c:1975:
+        error_report_exit("pSeries SLOF firmware requires >= %ldM guest RMA 
(Real Mode Area memory)",

ERROR: line over 90 characters
#1550: FILE: hw/scsi/vhost-scsi.c:174:
+        error_report_exit("vhost-scsi does not support changing the sense data 
and CDB sizes");

WARNING: line over 80 characters
#1598: FILE: hw/scsi/virtio-scsi.c:625:
+        error_report_exit("bad data written to virtio-scsi configuration 
space");

WARNING: line over 80 characters
#1667: FILE: hw/smbios/smbios.c:915:
+            error_report_exit("can't load type %d struct, fields already 
specified!",

WARNING: line over 80 characters
#1715: FILE: hw/smbios/smbios.c:1039:
+            error_report_exit("Don't know how to build fields for SMBIOS type 
%ld",

WARNING: line over 80 characters
#1911: FILE: hw/virtio/virtio.c:463:
+            error_report_exit("virtio: too many write descriptors in indirect 
table");

ERROR: line over 90 characters
#2097: FILE: qemu-img.c:2418:
+            error_report_exit("File contains external, encrypted or compressed 
clusters.");

WARNING: line over 80 characters
#2252: FILE: qemu-nbd.c:594:
+                error_report_exit("setting detect-zeroes to unmap is not 
allowed "

WARNING: line over 80 characters
#2318: FILE: qemu-nbd.c:656:
+                error_report_exit("Shared device number must be greater than 
0");

WARNING: line over 80 characters
#2641: FILE: target-ppc/kvm.c:2065:
+        error_report_exit("This vCPU type or KVM version does not support 
PAPR");

WARNING: line over 80 characters
#2666: FILE: target-s390x/cpu.c:403:
+        error_report_exit("Requested CPU state is not a valid S390 CPU state: 
%u",

WARNING: line over 80 characters
#2692: FILE: target-s390x/kvm.c:2183:
+        error_report_exit("Requested CPU state is not a valid S390 CPU state: 
%u",

WARNING: line over 80 characters
#2832: FILE: ui/spice-core.c:829:
+            error_report_exit("Failed to initialize EGL render node for SPICE 
GL");

WARNING: line over 80 characters
#3211: FILE: vl.c:3187:
+                    error_report_exit("only 90, 180, 270 deg rotation is 
available");

WARNING: line over 80 characters
#3323: FILE: vl.c:3681:
+                    error_report_exit("failed to parse UUID string: wrong 
format");

WARNING: line over 80 characters
#3352: FILE: vl.c:3722:
+                            error_report_exit("unsupported semihosting-config 
%s",

total: 6 errors, 22 warnings, 3019 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden