[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/10] arm: add support for an ast2500 evalua
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 09/10] arm: add support for an ast2500 evaluation board |
Date: |
Thu, 11 Aug 2016 11:34:37 +0100 |
On 2 August 2016 at 18:15, Cédric Le Goater <address@hidden> wrote:
> The ast2500 eval board has a hardware strapping register value of
> 0xF100C2E6 which we use for a definition of AST2500_EVB_HW_STRAP1
> below.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
>
> Changes since v2:
>
> - removed silicon-rev and cpu-model. This is now in the SoC.
>
> Changes since v1:
>
> - changed AST2500_EDK to AST2500_EVB
> - fixed white space issues
> - added AST2500_HW_STRAP1
>
> hw/arm/aspeed.c | 39 ++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 80907b4244ea..e71500c64bd3 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -36,7 +36,8 @@ typedef struct AspeedBoardConfig {
> } AspeedBoardConfig;
>
> enum {
> - PALMETTO_BMC
> + PALMETTO_BMC,
> + AST2500_EVB
Prefer trailing comma.
> };
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v3 06/10] palmetto-bmc: add board specific configuration, (continued)
- [Qemu-devel] [PATCH v3 07/10] hw/misc: use macros to define hw-strap1 register on the AST2400 Aspeed SoC, Cédric Le Goater, 2016/08/02
- [Qemu-devel] [PATCH v3 08/10] aspeed: add a AST2500 SoC and support to the SCU and SDMC controllers controllers, Cédric Le Goater, 2016/08/02
- [Qemu-devel] [PATCH v3 09/10] arm: add support for an ast2500 evaluation board, Cédric Le Goater, 2016/08/02
- [Qemu-devel] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard assignement, Cédric Le Goater, 2016/08/02
- Re: [Qemu-devel] [PATCH v3 00/10] arm: add ast2500 support, Peter Maydell, 2016/08/11