Re: [Qemu-devel] [PATCH v2 02/27] atomics: add atomic_op_fetch variants

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> From: "Emilio G. Cota" <address@hidden>
>
> This paves the way for upcoming work.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> Message-Id: <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>

> ---
>  include/qemu/atomic.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h
> index a5531da..d75bfde 100644
> --- a/include/qemu/atomic.h
> +++ b/include/qemu/atomic.h
> @@ -163,6 +163,14 @@
>  #define atomic_fetch_or(ptr, n)  __atomic_fetch_or(ptr, n, __ATOMIC_SEQ_CST)
>  #define atomic_fetch_xor(ptr, n) __atomic_fetch_xor(ptr, n, __ATOMIC_SEQ_CST)
>
> +#define atomic_inc_fetch(ptr)    __atomic_add_fetch(ptr, 1, __ATOMIC_SEQ_CST)
> +#define atomic_dec_fetch(ptr)    __atomic_sub_fetch(ptr, 1, __ATOMIC_SEQ_CST)
> +#define atomic_add_fetch(ptr, n) __atomic_add_fetch(ptr, n, __ATOMIC_SEQ_CST)
> +#define atomic_sub_fetch(ptr, n) __atomic_sub_fetch(ptr, n, __ATOMIC_SEQ_CST)
> +#define atomic_and_fetch(ptr, n) __atomic_and_fetch(ptr, n, __ATOMIC_SEQ_CST)
> +#define atomic_or_fetch(ptr, n)  __atomic_or_fetch(ptr, n, __ATOMIC_SEQ_CST)
> +#define atomic_xor_fetch(ptr, n) __atomic_xor_fetch(ptr, n, __ATOMIC_SEQ_CST)
> +
>  /* And even shorter names that return void.  */
>  #define atomic_inc(ptr)    ((void) __atomic_fetch_add(ptr, 1, 
> __ATOMIC_SEQ_CST))
>  #define atomic_dec(ptr)    ((void) __atomic_fetch_sub(ptr, 1, 
> __ATOMIC_SEQ_CST))
> @@ -358,6 +366,15 @@
>  #define atomic_fetch_and       __sync_fetch_and_and
>  #define atomic_fetch_or        __sync_fetch_and_or
>  #define atomic_fetch_xor       __sync_fetch_and_xor
> +
> +#define atomic_inc_fetch(ptr)  __sync_add_and_fetch(ptr, 1)
> +#define atomic_dec_fetch(ptr)  __sync_add_and_fetch(ptr, -1)
> +#define atomic_add_fetch       __sync_add_and_fetch
> +#define atomic_sub_fetch       __sync_sub_and_fetch
> +#define atomic_and_fetch       __sync_and_and_fetch
> +#define atomic_or_fetch        __sync_or_and_fetch
> +#define atomic_xor_fetch       __sync_xor_and_fetch
> +
>  #define atomic_cmpxchg         __sync_val_compare_and_swap
>
>  /* And even shorter names that return void.  */


--
Alex Bennée