[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes |
Date: |
Fri, 12 Aug 2016 16:59:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 11/08/2016 11:36, Lv Zheng wrote:
>
> - error_setg(errp, "'-acpitable' requires one of 'data' or 'file'");
> + val = qemu_opt_get((QemuOpts *)opts, "fadt");
> + if (val) {
> + unsigned long rev;
Don't use qemu_opt_get. Add the field to AcpiTableOptions in
qapi-schema.json, and then use hdrs->has_fadt, hdrs->fadt.
Paolo
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, (continued)
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Igor Mammedov, 2016/08/11
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Zheng, Lv, 2016/08/11
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Michael S. Tsirkin, 2016/08/11
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Zheng, Lv, 2016/08/14
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Michael S. Tsirkin, 2016/08/14
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Zheng, Lv, 2016/08/14
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Michael S. Tsirkin, 2016/08/14
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Zheng, Lv, 2016/08/14
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Igor Mammedov, 2016/08/12
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Zheng, Lv, 2016/08/15
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Zheng, Lv, 2016/08/14
- Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes, Paolo Bonzini, 2016/08/17