[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] fpu: add mechanism to check for invalid long
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v3] fpu: add mechanism to check for invalid long double formats |
Date: |
Mon, 15 Aug 2016 14:59:06 -0700 (PDT) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3] fpu: add mechanism to check for invalid long
double formats
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8a7e23e fpu: add mechanism to check for invalid long double formats
=== OUTPUT BEGIN ===
Checking PATCH 1/1: fpu: add mechanism to check for invalid long double
formats...
ERROR: do not use C99 // comments
#26: FILE: fpu/softfloat.c:4819:
+ return 1 << 31; // Integer indefinite value
ERROR: do not use C99 // comments
#37: FILE: fpu/softfloat.c:4851:
+ return 1 << 31; // Integer indefinite value
ERROR: do not use C99 // comments
#48: FILE: fpu/softfloat.c:4901:
+ return 1 << 63; // Integer indefinite value (64-bit)
ERROR: do not use C99 // comments
#59: FILE: fpu/softfloat.c:4946:
+ return 1 << 63; // Integer indefinite value (64-bit)
total: 4 errors, 0 warnings, 171 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden