qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()


From: Peter Xu
Subject: Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()
Date: Tue, 16 Aug 2016 22:00:18 +0800
User-agent: Mutt/1.5.24 (2015-08-30)

On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote:
> On Tue, 08/16 20:17, Peter Xu wrote:
> > > Do we really need error_report_exit when we already have error_fatal?
> > 
> > error_fatal is the name of a global var, not the function.
> 
> I mean most error_report_exit(...) calls can be converted to
> error_setg(&error_fatal, ...).

Right. But it's just another way to implement error_report_fatal(). We
may still need error_report_fatal() since it's cleaner and shorter
than error_setg(&error_fatal, ...).

-- peterx



reply via email to

[Prev in Thread] Current Thread [Next in Thread]