qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/9] tests: cris: fix syscall inline asm


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 2/9] tests: cris: fix syscall inline asm
Date: Mon, 5 Sep 2016 11:20:42 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 09/05/2016 04:54 AM, Rabin Vincent wrote:
From: Rabin Vincent <address@hidden>

Add the clobbered registeres to the inline asm for the write and exit
system calls.  Without the correct clobbers for the write() function,
correct failure messages are not printed succesfully on newer version of
GCC.

Signed-off-by: Rabin Vincent <address@hidden>
---
 tests/tcg/cris/sys.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/tcg/cris/sys.c b/tests/tcg/cris/sys.c
index 551c5dd..dfa5e1c 100644
--- a/tests/tcg/cris/sys.c
+++ b/tests/tcg/cris/sys.c
@@ -34,7 +34,10 @@ void *memset (void *s, int c, size_t n) {

 void exit (int status) {
        asm volatile ("moveq 1, $r9\n" /* NR_exit.  */
-                     "break 13\n");
+                     "break 13\n"
+                     :
+                     :
+                     : "r9", "memory" );

Better to simply set up the arguments properly.  See

http://www.uclibc-ng.org/browser/uclibc-ng/libc/sysdeps/linux/cris/bits/syscalls.h?rev=3b4650a23ff372dde44c264d43af8cfa4ac88e0a


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]