[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] target-ppc: tlbie should have global eff
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/3] target-ppc: tlbie should have global effect |
Date: |
Mon, 12 Sep 2016 16:08:50 +1000 |
On Mon, 2016-09-12 at 11:18 +0530, Nikunj A Dadhania wrote:
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 5026804..d96ff66 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -4448,6 +4448,7 @@ static void gen_tlbie(DisasContext *ctx)
> #if defined(CONFIG_USER_ONLY)
> GEN_PRIV;
> #else
> + TCGv_i32 t1;
> CHK_HV;
>
> if (NARROW_MODE(ctx)) {
> @@ -4458,6 +4459,11 @@ static void gen_tlbie(DisasContext *ctx)
> } else {
> gen_helper_tlbie(cpu_env, cpu_gpr[rB(ctx->opcode)]);
> }
> + t1 = tcg_temp_new_i32();
> + tcg_gen_ld_i32(t1, cpu_env, offsetof(CPUPPCState, tlb_need_flush));
> + tcg_gen_ori_i32(t1, t1, TLB_NEED_GLOBAL_FLUSH);
> + tcg_gen_st_i32(t1, cpu_env, offsetof(CPUPPCState, tlb_need_flush));
> + tcg_temp_free_i32(t1);
> #endif /* defined(CONFIG_USER_ONLY) */
Why not do this in the helper ?
Cheers,
Ben.
- [Qemu-devel] [PATCH v3 0/3] ppc: Broadcast tlb flush should have global effect, Nikunj A Dadhania, 2016/09/12
- [Qemu-devel] [PATCH v3 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag, Nikunj A Dadhania, 2016/09/12
- [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush(), Nikunj A Dadhania, 2016/09/12
- Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush(), David Gibson, 2016/09/13
- Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush(), Benjamin Herrenschmidt, 2016/09/13
- Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush(), Nikunj A Dadhania, 2016/09/13
- Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush(), Benjamin Herrenschmidt, 2016/09/14
- Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush(), Nikunj A Dadhania, 2016/09/14
- Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush(), David Gibson, 2016/09/14
[Qemu-devel] [PATCH v3 3/3] target-ppc: tlbie should have global effect, Nikunj A Dadhania, 2016/09/12
- Re: [Qemu-devel] [PATCH v3 3/3] target-ppc: tlbie should have global effect,
Benjamin Herrenschmidt <=
Re: [Qemu-devel] [PATCH v3 0/3] ppc: Broadcast tlb flush should have global effect, Benjamin Herrenschmidt, 2016/09/12