Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

[Laurent Vivier]

On 12/09/2016 03:27, David Gibson wrote:
> On Fri, Sep 09, 2016 at 02:31:55PM +0200, Laurent Vivier wrote:
>>
>>
>> On 09/09/2016 14:25, Greg Kurz wrote:
>>> On Thu, 8 Sep 2016 09:50:31 +0200
>>> Laurent Vivier <address@hidden> wrote:
>>>
>>>> On 08/09/2016 04:04, David Gibson wrote:
>>>>> On Tue, Sep 06, 2016 at 03:17:56PM +0200, Laurent Vivier wrote:  
>>>>>> And add support for ppc64.
>>>>>>
>>>>>> Signed-off-by: Laurent Vivier <address@hidden>  
>>>>>
>>>>> Some of my coments may be obsoleted by the discussion with Greg.
>>>>>   
>>>>>> ---
>>>>>> v2:
>>>>>> - remove useless parenthesis, inline
>>>> [...]
>>>>>> +
>>>>>> +QGuestAllocator *machine_alloc_init(void)
>>>>>> +{
>>>>>> +    const char *arch = qtest_get_arch();  
>>>>>
>>>>> Maybe we need to add a qtest_get_machine_type().  
>>>>
>>>> I'm working on that...
>>>>
>>>
>>> The problem is that qtest only knows about archs, based on $(TARGETS).
>>> Maybe the machine type could be the default one for a given arch ?
>>
>> Once the machine is started we can use QMP[1] to ask the machine type
>> (for instance, "pseries-2.7-machine").
>>
>> So what we could do is a generic qtest_machine_vboot() which ask the
>> machine type and configure the qtest framework accordingly.
>>
>> Laurent
>> [1] { 'execute': 'qom-get', 'arguments': { 'path': '/machine',
>> 'property': 'type' } }
> 
> Ok.. doesn't the qtest framework start the machine though?  So it
> should already know the machine type, shouldn't it?

In fact qtest starts the machine with the content of QTEST_QEMU_BINARY
and we don't provide "-machine" parameter, so it doesn't know the
machine type. It can guess it according to the machine arch, and by
default, ppc64 (arch) is pseries (machine).

Perhaps we can add "-machine pseries" in qtest_spapr_vboot().

Laurent
Laurent