Re: [Qemu-devel] [PATCH v11 3/6] qapi: rename QmpInputVisitor to QObjectInputVisitor

[Daniel P. Berrange]

On Mon, Sep 12, 2016 at 06:19:08PM +0200, Markus Armbruster wrote:
> "Daniel P. Berrange" <address@hidden> writes:
> 
> > The QmpInputVisitor has no direct dependancy on QMP. It is
> > valid to use it anywhere that one has a QObject. Rename it
> > to better reflect its functionality as a generic QObject
> > to QAPI convertor.
> >
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > ---
> >  docs/qapi-code-gen.txt                             |   2 +-
> >  ...qmp-input-visitor.h => qobject-input-visitor.h} |  10 +-
> >  monitor.c                                          |   2 +-
> >  qapi/Makefile.objs                                 |   2 +-
> >  ...qmp-input-visitor.c => qobject-input-visitor.c} | 171 
> > +++++++++++----------
> >  qmp.c                                              |   4 +-
> >  qom/qom-qobject.c                                  |   4 +-
> >  scripts/qapi-commands.py                           |   4 +-
> >  tests/.gitignore                                   |   4 +-
> >  tests/Makefile.include                             |  12 +-
> >  tests/check-qnull.c                                |   4 +-
> >  tests/test-qmp-commands.c                          |   4 +-
> >  ...-input-strict.c => test-qobject-input-strict.c} |   4 +-
> >  ...nput-visitor.c => test-qobject-input-visitor.c} |   4 +-
> >  tests/test-string-input-visitor.c                  |   2 +-
> >  tests/test-visitor-serialization.c                 |   4 +-
> >  util/qemu-sockets.c                                |   2 +-
> >  17 files changed, 121 insertions(+), 118 deletions(-)
> >  rename include/qapi/{qmp-input-visitor.h => qobject-input-visitor.h} (63%)
> >  rename qapi/{qmp-input-visitor.c => qobject-input-visitor.c} (56%)
> >  rename tests/{test-qmp-input-strict.c => test-qobject-input-strict.c} (99%)
> >  rename tests/{test-qmp-input-visitor.c => test-qobject-input-visitor.c} 
> > (99%)
> 
> $ git-grep -Ei 'qmp.?input.*?vis'
> include/qapi/visitor.h: * the dealloc and QMP input/output visitors are 
> general, the string,
> target-s390x/cpu_models.c:#include "qapi/qmp-input-visitor.h"
> target-s390x/cpu_models.c:        visitor = 
> qmp_input_visitor_new(info->props, true);
> tests/test-qobject-input-strict.c: * QMP Input Visitor unit-tests (strict 
> mode).
> tests/test-qobject-input-visitor.c: * QMP Input Visitor unit-tests.

Opps, yes will fix those.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|