|
From: | Lluís Vilanova |
Subject: | Re: [Qemu-devel] [PATCH v2 6/6] trace: use -1 instead of TRACE_VCPU_EVENT_COUNT as magic value |
Date: | Thu, 15 Sep 2016 01:12:39 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Daniel P Berrange writes: > The TraceEvent struct vcpu_id field uses the constant > TRACE_VCPU_EVENT_COUNT as a magic value to indicate this > is not a per-VCPU event. The max count value will be > different for each event group though, so this is no > longer suitable. Instead use the value (size_t)-1 which > is guaranteed to be available across all event groups. The tracetool script should assert used vcpu IDs never reach ~0. Also, this patch is better sent with your actual event group patches (see comments on patch 5). Cheers, Lluis
[Prev in Thread] | Current Thread | [Next in Thread] |