[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] 9pfs: drop duplicate line in proxy backend
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] 9pfs: drop duplicate line in proxy backend |
|
Date: |
Thu, 15 Sep 2016 17:05:51 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/15/2016 04:24 PM, Greg Kurz wrote:
> This double free did not cause harm because v9fs_string_free() sets
> str->data to NULL and g_free(NULL) is valid.
>
> Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
> ---
> hw/9pfs/9p-proxy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c
> index 52bbf4f1b37c..d091564b6fd2 100644
> --- a/hw/9pfs/9p-proxy.c
> +++ b/hw/9pfs/9p-proxy.c
> @@ -775,11 +775,10 @@ static int proxy_mkdir(FsContext *fs_ctx, V9fsPath
> *dir_path,
> v9fs_string_free(&fullname);
> if (retval < 0) {
> errno = -retval;
> retval = -1;
> }
> - v9fs_string_free(&fullname);
> return retval;
> }
>
> static int proxy_fstat(FsContext *fs_ctx, int fid_type,
> V9fsFidOpenState *fs, struct stat *stbuf)
>
>