[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in virtio_gpu_resou
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in virtio_gpu_resource_create_2d |
Date: |
Mon, 19 Sep 2016 07:47:48 +0000 |
On Mon, Sep 19, 2016 at 6:08 AM Li Qiang <address@hidden> wrote:
> From: Li Qiang <address@hidden>
>
> In virtio gpu resource create dispatch, if the pixman format is zero
> it doesn't free the resource object allocated previously. Thus leading
> a host memory leak issue. This patch avoid this.
>
> Signed-off-by: Li Qiang <address@hidden>
>
Reviewed-by: Marc-André Lureau <address@hidden>
---
> hw/display/virtio-gpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 7fe6ed8..5b6d17b 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -333,6 +333,7 @@ static void virtio_gpu_resource_create_2d(VirtIOGPU *g,
> qemu_log_mask(LOG_GUEST_ERROR,
> "%s: host couldn't handle guest format %d\n",
> __func__, c2d.format);
> + g_free(res);
> cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER;
> return;
> }
> --
> 1.8.3.1
>
>
> --
Marc-André Lureau