[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] seccomp missing calls in 2.7.0?
From: |
Eduardo Otubo |
Subject: |
Re: [Qemu-devel] seccomp missing calls in 2.7.0? |
Date: |
Mon, 19 Sep 2016 11:47:37 +0200 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Sep 19, 2016 at 11=45=47AM +0200, Markus Armbruster wrote:
> Brian Rak <address@hidden> writes:
>
> > getrusage is used in a number of places throughout the qemu codebase
> > (notably, in crypto/pbkdf.c).
> > Without this syscall being whitelisted, qemu ends up getting killed by
> > the kernel whenever you
> > try to connect to a VNC console.
>
> The body of the commit message now looks good to me, but the headline is
> still off. It should be something like "seccomp: Add getrusage() to
> whitelist".
>
> Perhaps Eduardo is willing to touch it up on commit. If not, you need
> to resend your patch as a top-level message (not in reply to anything)
> with the subject fixed. Please consider using git-send-email. Thanks!
>
> http://wiki.qemu.org/Contribute/SubmitAPatch#Submitting_your_Patches
Yep, that's not a problem now. I'll fix that. But yeah, please stick to
the guidelines next time :)
Regards,
--
Eduardo Otubo
ProfitBricks GmbH
signature.asc
Description: PGP signature