[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2/8] tcg/optimize: move default return out of if s
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [RFC 2/8] tcg/optimize: move default return out of if statement |
Date: |
Tue, 20 Sep 2016 08:02:53 +0000 |
On Mon, Sep 19, 2016 at 7:56 PM Alex Bennée <address@hidden> wrote:
> This is to appease sanitizer builds which complain that:
>
> "error: control reaches end of non-void function"
>
> Signed-off-by: Alex Bennée <address@hidden>
>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> tcg/optimize.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 9998ac7..0f13490 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -468,9 +468,8 @@ static TCGArg do_constant_folding_cond(TCGOpcode op,
> TCGArg x,
> default:
> return 2;
> }
> - } else {
> - return 2;
> }
> + return 2;
> }
>
> /* Return 2 if the condition can't be simplified, and the result
> --
> 2.9.3
>
>
> --
Marc-André Lureau
[Qemu-devel] [RFC 3/8] new: blacklist.tsan, Alex Bennée, 2016/09/19