[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object |
Date: |
Wed, 21 Sep 2016 12:15:25 +1000 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Sep 21, 2016 at 12:05:47PM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2016-09-21 at 11:51 +1000, David Gibson wrote:
> > Ok, as noted elsewhere, I think you need to disassociate the PIR value
> > from the cpu_index. It may be a little less elegant, but it'll make
> > your life much easier in the short and medium term.
> >
> > Apart from that, this looks pretty good, though I have one suggested
> > cleanup below.
>
> As long as the PIR value is what is used everywhere, ie, interrupt
> controller, XSCOM addressing of the cores, Doorbells, etc...
Right, obviously the physical ID needs to be used for all the guest
visible interfaces.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature