Re: [Qemu-devel] [PATCH 3/9] docker: Generate /packages.txt in ubuntu image

[Daniel P. Berrange]

On Wed, Sep 21, 2016 at 11:49:22AM +0800, Fam Zheng wrote:
> Put the list of package names in an environment, and output their
> package names to the target file in the end.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  tests/docker/dockerfiles/ubuntu.docker | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/ubuntu.docker 
> b/tests/docker/dockerfiles/ubuntu.docker
> index a8b88c3..a360a05 100644
> --- a/tests/docker/dockerfiles/ubuntu.docker
> +++ b/tests/docker/dockerfiles/ubuntu.docker
> @@ -2,10 +2,12 @@ FROM ubuntu:14.04
>  RUN echo "deb http://archive.ubuntu.com/ubuntu/ trusty universe multiverse" 
> >> \
>      /etc/apt/sources.list
>  RUN apt-get update
> -RUN apt-get -y install flex bison \
> +ENV PACKAGES flex bison \
>      libusb-1.0-0-dev libiscsi-dev librados-dev libncurses5-dev \
>      libseccomp-dev libgnutls-dev libssh2-1-dev  libspice-server-dev \
>      libspice-protocol-dev libnss3-dev libfdt-dev \
>      libgtk-3-dev libvte-2.90-dev libsdl1.2-dev libpng12-dev libpixman-1-dev \
>      git make ccache python-yaml gcc clang sparse
> +RUN apt-get -y install $PACKAGES
> +RUN dpkg -l $PACKAGES | sort > /packages.txt
>  ENV FEATURES clang pyyaml

Reviewed-by: Daniel. P. Berrange <address@hidden>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|