[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop |
Date: |
Wed, 21 Sep 2016 16:01:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/21/2016 03:18 PM, Paolo Bonzini wrote:
> This series started as an attempt to always use the dataplane path
> for virtio-blk and virtio-scsi when ioeventfd is active. The aim
> was three-fold:
>
> 1) to add more coverage for dataplane
>
> 2) to remove virtio_add_queue_aio
>
> 3) to simplify the dataplane start/stop code
>
> It achieves the first two objectives, and while it doesn't quite
> achieve the third it does cleanup the generic ioeventfd code in
> virtio-bus more than I expected. In particular, it reduces the set
> of callbacks that transports must implement, and it removes the ugly
> case where ioeventfd is started with generic callbacks and then moved
> to the dataplane callbacks. It also enables some simplification of the
> functions that deal with host notifiers.
>
> I've tested it with virtio-blk, virtio-scsi and vhost-net.
>
> Patches 1 and 2 are simplifications that are too nice to leave
> them for later in the series.
>
> Patch 3 moves some of the ioeventfd code from virtio-bus.c to
> virtio.c. At this point the transition is a bit half-assed, but
> this changes as soon as we remove the generic->dataplane
> handler transition.
>
> Patches 4 to 6 do exactly that, and then the spring cleaning
> begins, lasting for the whole second half of the series.
>
> Opinions, reviews and bug reports?
is there a branch?
- Re: [Qemu-devel] [PATCH 07/12] Revert "virtio: Introduce virtio_add_queue_aio", (continued)
- [Qemu-devel] [PATCH 06/12] virtio-scsi: always use dataplane path if ioeventfd is active, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 11/12] virtio: inline virtio_queue_set_host_notifier_fd_handler, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 10/12] virtio: do not export set_host_notifier_internal, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 09/12] virtio: remove ioeventfd_disabled altogether, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 08/12] virtio: remove set_handler argument from set_host_notifier_internal, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 12/12] virtio: inline set_host_notifier_internal, Paolo Bonzini, 2016/09/21
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop,
Christian Borntraeger <=
Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Michael S. Tsirkin, 2016/09/21
Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Stefan Hajnoczi, 2016/09/30