[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select
From: |
Riku Voipio |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select |
Date: |
Thu, 22 Sep 2016 04:25:46 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sun, Sep 04, 2016 at 03:49:22PM +0200, Laurent Vivier wrote:
> Le 11/07/2016 à 18:59, Peter Maydell a écrit :
> > On 8 July 2016 at 00:17, Laurent Vivier <address@hidden> wrote:
> >> TARGET_NR_select can have three different implementations:
> >>
> >> 1- to always return -ENOSYS
> >>
> >> microblaze, ppc, ppc64
> >>
> >> -> TARGET_WANT_NI_OLD_SELECT
> >>
> >> 2- to take parameters from a structure pointed by arg1
> >> (kernel sys_old_select)
> >>
> >> i386, arm, m68k
> >>
> >> -> TARGET_WANT_OLD_SYS_SELECT
> >>
> >> 3- to take parameters from arg[1-5]
> >> (kernel sys_select)
> >>
> >> x86_64, alpha, s390x,
> >> cris, sparc, sparc64
> >>
> >> Some (new) architectures don't define NR_select,
> >>
> >> 4- but only NR__newselect with sys_select:
> >>
> >> mips, mips64, sh
> >>
> >> 5- don't define NR__newselect, and use pselect6 syscall:
> >>
> >> aarch64, openrisc, tilegx, unicore32
> >>
> >> Reported-by: Timothy Pearson <address@hidden>
> >> Reported-by: Allan Wirth <address@hidden>
> >> Suggested-by: Peter Maydell <address@hidden>
> >> Signed-off-by: Laurent Vivier <address@hidden>
> >> ---
> >
> > Reviewed-by: Peter Maydell <address@hidden>
> >
>
> It seems this one has missed 2.7 window, perhaps it can queued for 2.8?
Thanks for the reminder, applied to linux-user que
Riku