[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 11/17] trace: provide mechanism for registeri
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v4 11/17] trace: provide mechanism for registering trace events |
Date: |
Thu, 22 Sep 2016 13:48:38 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Thu, Sep 22, 2016 at 02:44:11PM +0200, Lluís Vilanova wrote:
> Daniel P Berrange writes:
>
> > Remove the notion of there being a single global array
> > of trace events, by introducing a method for registering
> > groups of events.
>
> > Signed-off-by: Daniel P. Berrange <address@hidden>
>
> Except for the calls to module_call_init() (I did not check if they're all
> necessary and sufficient):
Every binary that can trigger tracepoints should have the module_call_init().
I'd done it for emulators, qemu-img, qemu-nbd, and qemu-io. I could tell
which need it, since they're the ones that need to link to the trace.o
files, otherwise you'll unresolved symbol errors. So I think what I have
is correct.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v4 04/17] trace: remove global 'uint16 dstate[]' array, (continued)
- [Qemu-devel] [PATCH v4 04/17] trace: remove global 'uint16 dstate[]' array, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 07/17] trace: give each trace event a named TraceEvent struct, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 10/17] trace: don't abort qemu if ftrace can't be initialized, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 09/17] trace: emit name <-> ID mapping in simpletrace header, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 08/17] trace: remove the TraceEventID and TraceEventVCPUID enums, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 11/17] trace: provide mechanism for registering trace events, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 12/17] trace: dynamically allocate trace_dstate in CPUState, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 13/17] trace: dynamically allocate event IDs at runtime, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 14/17] trace: get rid of generated-events.h/generated-events.c, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 16/17] trace: push reading of events up a level to tracetool main, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 17/17] trace: pass trace-events to tracetool as a positional param, Daniel P. Berrange, 2016/09/22
- [Qemu-devel] [PATCH v4 15/17] trace: rename _read_events to read_events, Daniel P. Berrange, 2016/09/22