[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 5/8] hw/intc/arm_gicv3_its: Implement support
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v6 5/8] hw/intc/arm_gicv3_its: Implement support for in-kernel ITS emulation |
Date: |
Thu, 22 Sep 2016 16:59:18 +0100 |
On 22 September 2016 at 16:53, Auger Eric <address@hidden> wrote:
> Hi Peter,
>
> On 22/09/2016 17:03, Peter Maydell wrote:
>> Also, I think it would be simpler to just have kvm_its_send_msi() do
>>
>> if (unlikely(!s->translater_gpa_known)) {
>> s->gits_translater_gpa = ...;
>> s->translater_gpa_known = true;
>> }
> My issue precisely is to get the absolue GPA of the ITS translater.
> kvm_its_send_msi is called by the region write callback which works on
> relative address wrt start of the translation region while kvm ioctl
> uses the absolute GPA. I did not see any other way to retrieve the
> absolute GPA than using a machine init done notifier.
I don't understand. There should be no difference between
(1) calculate gits_translater_gpa in the machine init done notifier
(2) calculate gits_translater_gpa the first time that we need it,
ie on first call to kvm_its_send_msi()
We don't use it anywhere else, do we ?
thanks
-- PMM
- [Qemu-devel] [PATCH v6 2/8] hw/intc/arm_gicv3_its: Implement ITS base class, (continued)
- [Qemu-devel] [PATCH v6 2/8] hw/intc/arm_gicv3_its: Implement ITS base class, Eric Auger, 2016/09/09
- [Qemu-devel] [PATCH v6 4/8] kvm-all: Pass requester ID to MSI routing functions, Eric Auger, 2016/09/09
- [Qemu-devel] [PATCH v6 3/8] target-arm: move gicv3_class_name from machine to kvm_arm.h, Eric Auger, 2016/09/09
- [Qemu-devel] [PATCH v6 6/8] arm/virt: Add ITS to the virt board, Eric Auger, 2016/09/09
- [Qemu-devel] [PATCH v6 5/8] hw/intc/arm_gicv3_its: Implement support for in-kernel ITS emulation, Eric Auger, 2016/09/09
[Qemu-devel] [PATCH v6 8/8] ARM: Virt: ACPI: Add GIC ITS description in ACPI MADT table, Eric Auger, 2016/09/09
[Qemu-devel] [PATCH v6 7/8] ACPI: Add GIC Interrupt Translation Service Structure definition, Eric Auger, 2016/09/09
Re: [Qemu-devel] [PATCH v6 0/8] vITS support, Peter Maydell, 2016/09/22