[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] intel_iommu: pass whole remapped addresses
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] intel_iommu: pass whole remapped addresses to apic |
Date: |
Fri, 23 Sep 2016 17:41:22 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Sep 22, 2016 at 11:04:30PM +0200, Radim Krčmář wrote:
[...]
> @@ -279,18 +280,16 @@ static void vtd_update_iotlb(IntelIOMMUState *s,
> uint16_t source_id,
> static void vtd_generate_interrupt(IntelIOMMUState *s, hwaddr mesg_addr_reg,
> hwaddr mesg_data_reg)
> {
> - hwaddr addr;
> - uint32_t data;
> + MSIMessage msi;
>
> assert(mesg_data_reg < DMAR_REG_SIZE);
> assert(mesg_addr_reg < DMAR_REG_SIZE);
>
> - addr = vtd_get_long_raw(s, mesg_addr_reg);
> - data = vtd_get_long_raw(s, mesg_data_reg);
> + msi.address = vtd_get_long_raw(s, mesg_addr_reg);
> + msi.data = vtd_get_long_raw(s, mesg_data_reg);
>
> VTD_DPRINTF(FLOG, "msi: addr 0x%"PRIx64 " data 0x%"PRIx32, addr, data);
Need to fix addr/data as well?
-- peterx
- [Qemu-devel] [PATCH 0/5] intel_iommu: fix EIM, Radim Krčmář, 2016/09/22
- [Qemu-devel] [PATCH 1/5] apic: add global apic_get_class(), Radim Krčmář, 2016/09/22
- [Qemu-devel] [PATCH 3/5] intel_iommu: pass whole remapped addresses to apic, Radim Krčmář, 2016/09/22
- [Qemu-devel] [PATCH 4/5] intel_iommu: add "eim" property, Radim Krčmář, 2016/09/22
- [Qemu-devel] [PATCH 2/5] apic: add send_msi() to APICCommonClass, Radim Krčmář, 2016/09/22
- [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support, Radim Krčmář, 2016/09/22