qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 04/17] trace: remove global 'uint16 dstate[]'


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v4 04/17] trace: remove global 'uint16 dstate[]' array
Date: Fri, 23 Sep 2016 14:51:25 +0100
User-agent: Mutt/1.7.0 (2016-08-17)

On Thu, Sep 22, 2016 at 09:40:39AM +0100, Daniel P. Berrange wrote:
> Instead of having a global dstate array, declare a single
> 'uint16 TRACE_${EVENT_NAME}_DSTATE' variable for each
> trace event. Record a pointer to this variable in the
> TraceEvent struct too.
> 
> By turning trace_event_get_state_dynamic_by_id into a
> macro, this still hits the fast path, and cache affinity
> is ensured by declaring all the uint16 vars adjacent to
> each other.
> 
> Reviewed-by: Lluís Vilanova <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  scripts/tracetool/__init__.py        |  3 ++-
>  scripts/tracetool/format/events_c.py |  9 +++++++--
>  scripts/tracetool/format/events_h.py |  3 +++
>  stubs/trace-control.c                |  9 ++++-----
>  trace/control-internal.h             | 14 ++++----------
>  trace/control-target.c               | 20 ++++++++------------
>  trace/control.c                      | 11 ++---------
>  trace/event-internal.h               |  7 +++++++
>  8 files changed, 37 insertions(+), 39 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]