Re: [Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray

[John Snow]

On 09/23/2016 11:35 AM, Max Reitz wrote:
> On 23.09.2016 03:45, John Snow wrote:
> > When I said "Final re-send," I was lying. Here's a v5.
> > The title is also a misnomer by now :)
> >
> > The move to blk_flush altered the behavior of migration and flushing
> > nodes that are not reachable via the guest, but are still reachable
> > via QEMU and may or may not need to be flushed.
> >
> > This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt
> > et al being unable to migrate QEMU when the CDROM tray is open.
> >
> > v5:
> >  Fix bracket spacing in patch 1. By one space. :(
> >  Added third patch to remove blk_flush_all.
> >
> > v4:
> >  Commit message update.
> >
> > v3:
> >  Reworking approach and reinstating bdrv_flush_all at Kevin's suggestion.
> >
> > ________________________________________________________________________________
> >
> > For convenience, this branch is available at:
> > https://github.com/jnsnow/qemu.git branch atapi-tray-migfix
> > https://github.com/jnsnow/qemu/tree/atapi-tray-migfix
> >
> > This version is tagged atapi-tray-migfix-v5:
> > https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v5
> >
> > John Snow (3):
> >   block: reintroduce bdrv_flush_all
> >   qemu: use bdrv_flush_all for vm_stop et al
> >   block-backend: remove blk_flush_all
> >
> >  block/block-backend.c          | 22 ----------------------
> >  block/io.c                     | 25 +++++++++++++++++++++++++
> >  cpus.c                         |  4 ++--
> >  hw/i386/xen/xen_platform.c     |  2 --
> >  hw/ide/piix.c                  |  4 ++++
> >  include/block/block.h          |  1 +
> >  include/sysemu/block-backend.h |  1 -
> >  7 files changed, 32 insertions(+), 27 deletions(-)
>
> Reviewed-by: Max Reitz <address@hidden>

Since Fam acked this, I suppose it's for Kevin's tree?

--js