qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)


From: Eduardo Habkost
Subject: Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)
Date: Fri, 23 Sep 2016 16:49:27 -0300
User-agent: Mutt/1.7.0 (2016-08-17)

On Thu, Sep 22, 2016 at 02:49:35PM -0500, Corey Minyard wrote:
> On 09/22/2016 01:42 PM, Eduardo Habkost wrote:
[...]
> > In the case of the inject-nmi QMP command, I need to understand
> > what "default CPU" is supposed to mean in the inject-nmi
> > documentation. Maybe it can be changed to use the first CPU, too
> > (that's probably the existing behavior because there's no way to
> > change cur_mon->mon_cpu in a QMP monitor).
> > 
> I looked through is a bit, and the only place I found it was used was
> the x390 code.
> 
> If we remove the CPU index from this, then the IPMI device can
> keep the same interface.

Well, the existing behavior is to use the first CPU, so I will
just keep the existing behavior but remove the
monitor_get_cpu_index() call from qmp_inject_nmi(). Then the IPMI
code can stay the same.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]