qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
Date: Sat, 24 Sep 2016 18:10:37 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0


On 24/09/2016 00:05, Michael S. Tsirkin wrote:
>> e events...
>> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
>> > ERROR: struct MemoryRegionIOMMUOps should normally be const
>> > #1527: FILE: hw/i386/amd_iommu.h:280:
>> > +    MemoryRegionIOMMUOps iommu_ops;
> 
> False positive.

Not quite, there's no reason for the ops to be inside AMDVIState rather
than a (static) global.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]