Re: [Qemu-devel] [PATCH 0/6] intc: change 'info irq' and 'info pic' to be target-agnostic

[Paolo Bonzini]

On 25/09/2016 20:36, Hervé Poussineau wrote:
> 
> This patchset aims at genericizing the 'info irq' and 'info pic' HMP 
> commands, so
> that it is available on all machines and can display details about more than 
> one
> interrupt controller per machine.
> 
> Patch 1 adds a new interface IntCtrl, which is used to:
> - gather statistics for the 'info irq' command
> - print some text when 'info pic' is called
> 
> Patches 2 to 4 implement IntCtrl interface on interrupt controllers which have
> ad-hock code to handle 'info irq'/'info pic' commands.
> 
> Patch 5 removes ad-hock code, and replaces it by a generic version. You can 
> get
> details about multiple interrupt controllers per machine starting here.
> 
> Patch 6 makes 'info irq'/'info pic' commands available on all architectures.
> For example, Alpha clipper machine is now able to display details about the
> i8259 interrupt controller.

Nice.  The only remark is that I'd change IntCtrl to something more
descriptive such as InterruptStatsProvider.

Paolo