[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip |
Date: |
Mon, 26 Sep 2016 10:23:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 23/09/2016 05:47, Wanpeng Li wrote:
> From: Wanpeng Li <address@hidden>
>
> The qemu will crash when info ioapic through hmp if irqchip
> is split. Below message is splat:
>
> KVM_GET_IRQCHIP failed: Unknown error -6
>
> This patch fix it by dumping the ioapic state from the qemu
> emulated ioapic if irqchip is split.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Signed-off-by: Wanpeng Li <address@hidden>
> ---
> target-i386/monitor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target-i386/monitor.c b/target-i386/monitor.c
> index fccfe40..bf1e983 100644
> --- a/target-i386/monitor.c
> +++ b/target-i386/monitor.c
> @@ -504,7 +504,8 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qdict)
>
> void hmp_info_io_apic(Monitor *mon, const QDict *qdict)
> {
> - if (kvm_irqchip_in_kernel()) {
> + if (kvm_irqchip_in_kernel() &&
> + !kvm_irqchip_is_split()) {
> kvm_ioapic_dump_state(mon, qdict);
> } else {
> ioapic_dump_state(mon, qdict);
>
Queued, thanks.