[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure |
Date: |
Tue, 27 Sep 2016 20:17:26 +1000 |
On Tue, 2016-09-27 at 11:10 +0200, Cédric Le Goater wrote:
> >
> > >
> > > + PowerPCCPU *cpu = POWERPC_CPU(cs);
> > > + CPUPPCState *env = &cpu->env;
> > > +
> > > + cpu_synchronize_state(cs);
> > > + env->spr[SPR_HMER] |= hmer_bits;
> > > +
> > > + /* XXX Need a CPU helper to set HMER, also handle gneeration
> > > + * of HMIs
> > > + */
>
> Ben,
>
> The CPU helper would be to replicate the value of the SPR_HMER in all
> the threads of the core I guess ?
Nope, those HMER bits are per-thread afaik, but I dislike having a
device whack at CPU state...
Also when we do PR KVM of powernv, we'll want to sync the SPR with KVM
I suppose.
Cheers,
Ben.
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, (continued)
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Cédric Le Goater, 2016/09/22
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, David Gibson, 2016/09/22
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Cédric Le Goater, 2016/09/26
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, David Gibson, 2016/09/26
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Cédric Le Goater, 2016/09/27
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Benjamin Herrenschmidt, 2016/09/27
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Cédric Le Goater, 2016/09/27
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Cédric Le Goater, 2016/09/27
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Cédric Le Goater, 2016/09/27
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Benjamin Herrenschmidt, 2016/09/27
- Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure,
Benjamin Herrenschmidt <=
[Qemu-devel] [PATCH v3 09/10] ppc/pnv: add a LPC controller, Cédric Le Goater, 2016/09/15
[Qemu-devel] [PATCH v3 10/10] ppc/pnv: add a ISA bus, Cédric Le Goater, 2016/09/15