|
From: | Roy Shterman |
Subject: | Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU |
Date: | Tue, 27 Sep 2016 14:58:10 +0300 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 9/27/2016 2:52 PM, Paolo Bonzini wrote:
right, but because libvirt inbox versions doesn't support protocol_name=iser I decided to leave both options available. The ?iser option and the iser:// option, to also have compatibility with inbox Libvirt versions.On 27/09/2016 13:37, Roy Shterman wrote:+ iscsi_url = iscsi_parse_full_url(iscsi, uri_string_unescape(filename, -1, NULL)); if (iscsi_url == NULL) { - error_setg(errp, "Failed to parse URL : %s", filename); + error_setg(errp, "Failed to parse URL : %s", uri_string_unescape(filename, -1, NULL));uri_string_unescape() returns a newly allocated string. This is a memory leak!will be fixed in v3Is unescaping a bug fix? Please put it into a separate patch.because libvirt is parsing '?' char as %3F, I needed to parse to URI with unescaping.This looks like a libvirt bug. But if libvirt learns to pass iser:// URIs, the unescape is not necessary, is it?
Thanks, Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |